daos icon indicating copy to clipboard operation
daos copied to clipboard
verified publisher icon daos-stack

DAOS-11605 common: add a few umem APIs

Open liuxuezhao opened this issue 3 years ago • 2 comments

Add umem_tx_act_nr/_act_payload_sz/_act_first/_act_next APIs, and related umm_ops. Add definition of "struct umem_tx", in AD TX implementation can use TLS to cache a umem_tx pointer similar as PMDK. But need to take out umem_tx and reset TLS' tx pointer before calling bio_wal_commit() as it possibly yield. TODO: hook UMEM_CLASS_AD types umm_ops with ad_tx.

Required-githooks: true Signed-off-by: Xuezhao Liu [email protected]

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [ ] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficent testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

liuxuezhao avatar Oct 13 '22 06:10 liuxuezhao

Bug-tracker data: Ticket title is 'Implement new alternative umem allocator from scratch' Status is 'In Progress' Labels: 'md_on_ssd' Job should run at elevated priority (3) https://daosio.atlassian.net/browse/DAOS-11605

github-actions[bot] avatar Oct 13 '22 06:10 github-actions[bot]

Test stage Unit Test on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/1/execution/node/618/log

daosbuild1 avatar Oct 13 '22 07:10 daosbuild1

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10557/3/testReport/(root)/

daosbuild1 avatar Oct 20 '22 17:10 daosbuild1

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10557/4/testReport/(root)/

daosbuild1 avatar Oct 23 '22 10:10 daosbuild1

Test stage Unit Test on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/6/execution/node/619/log

daosbuild1 avatar Oct 26 '22 10:10 daosbuild1

Test stage Unit Test with memcheck on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/6/execution/node/625/log

daosbuild1 avatar Oct 26 '22 10:10 daosbuild1

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10557/7/testReport/(root)/

daosbuild1 avatar Oct 26 '22 13:10 daosbuild1

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10557/8/testReport/(root)/

daosbuild1 avatar Oct 26 '22 19:10 daosbuild1

I didn't see the new umem API for generating redo log, it'll be added in a follow-on PR?

seems can reuse umem_tx_add_range/umem_tx_add_ptr APIs? may need to add a flag parameter to add new flag, to bridge to "ad_tx_snap(..., AD_TX_REDO);"? adding new umem API also fine. That will need to change some DAOS server code as what we discussed yesterday. Do you want me to make the change or you want to change it by yourself?

I just refresh the patch, let's address the umem API for redo at a follow-on PR, thx

liuxuezhao avatar Oct 27 '22 03:10 liuxuezhao

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/10/execution/node/146/log

daosbuild1 avatar Oct 27 '22 09:10 daosbuild1

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10557/12/testReport/(root)/

daosbuild1 avatar Oct 27 '22 12:10 daosbuild1

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10557/13/testReport/(root)/

daosbuild1 avatar Oct 28 '22 10:10 daosbuild1

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/14/execution/node/311/log

daosbuild1 avatar Oct 30 '22 15:10 daosbuild1

Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/14/execution/node/308/log

daosbuild1 avatar Oct 30 '22 15:10 daosbuild1

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/14/execution/node/342/log

daosbuild1 avatar Oct 30 '22 15:10 daosbuild1

Test stage Unit Test on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/15/execution/node/625/log

daosbuild1 avatar Oct 30 '22 15:10 daosbuild1

Test stage Unit Test with memcheck on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/15/execution/node/626/log

daosbuild1 avatar Oct 30 '22 15:10 daosbuild1

Test stage Unit Test on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/16/execution/node/625/log

daosbuild1 avatar Oct 31 '22 05:10 daosbuild1

Test stage Unit Test with memcheck on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/16/execution/node/606/log

daosbuild1 avatar Oct 31 '22 05:10 daosbuild1

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10557/17/execution/node/851/log

daosbuild1 avatar Oct 31 '22 08:10 daosbuild1

Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-10557/17/display/redirect

daosbuild1 avatar Oct 31 '22 09:10 daosbuild1