daos icon indicating copy to clipboard operation
daos copied to clipboard
verified publisher icon daos-stack

DAOS-10666 dfs: Get only needed props during mount

Open kjacque opened this issue 3 years ago • 4 comments

Instead of requesting all props, including ACL, dfs_mount should request only those that it needs. All of the requested props are available to users with get_prop access on the container.

Signed-off-by: Kris Jacque [email protected]

Before requesting gatekeeper:

  • [ ] Two review approvals and any prior change requests have been resolved.
  • [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • [x] Commit messages follows the guidelines outlined here.
  • [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • [ ] You are the appropriate gatekeeper to be landing the patch.
  • [ ] The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • [ ] Githooks were used. If not, request that user install them and check copyright dates.
  • [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • [ ] All builds have passed. Check non-required builds for any new compiler warnings.
  • [ ] Sufficent testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • [ ] If applicable, the PR has addressed any potential version compatibility issues.
  • [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • [ ] Extra checks if forced landing is requested
    • [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • [ ] No new NLT or valgrind warnings. Check the classic view.
    • [ ] Quick-build or Quick-functional is not used.
  • [ ] Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

kjacque avatar Oct 13 '22 00:10 kjacque

Bug-tracker data: Ticket title is 'DAOS_ACL_PERM_GET_ACL permission needed to read container properties.' Status is 'In Review' Labels: 'triaged' Job should run at elevated priority (3) https://daosio.atlassian.net/browse/DAOS-10666

github-actions[bot] avatar Oct 13 '22 00:10 github-actions[bot]

This looks like it would work, it would be good to get a test for it if we can. I'll try and work on one tomorrow so it would be good to include in this PR and include the fix and the test in the same commit.

ashleypittman avatar Oct 13 '22 11:10 ashleypittman

This looks like it would work, it would be good to get a test for it if we can. I'll try and work on one tomorrow so it would be good to include in this PR and include the fix and the test in the same commit.

Thanks! I only verified manually. A new test would be great (maybe part of NLT?).

kjacque avatar Oct 13 '22 14:10 kjacque

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10556/2/testReport/(root)/

daosbuild1 avatar Oct 15 '22 08:10 daosbuild1

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10556/3/execution/node/859/log

daosbuild1 avatar Oct 18 '22 02:10 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10556/3/execution/node/1134/log

daosbuild1 avatar Oct 18 '22 08:10 daosbuild1

This looks like it would work, it would be good to get a test for it if we can. I'll try and work on one tomorrow so it would be good to include in this PR and include the fix and the test in the same commit.

I had a quick go at this and without multiple users to assign a container to it's not all that easy to setup standalone. The multi-user code will cover this functionality though (I've cherry-picked this PR into that one for now).

ashleypittman avatar Oct 18 '22 20:10 ashleypittman

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10556/5/execution/node/1131/log

daosbuild1 avatar Oct 19 '22 13:10 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10556/5/execution/node/1084/log

daosbuild1 avatar Oct 19 '22 14:10 daosbuild1

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-10556/6/testReport/(root)/

daosbuild1 avatar Oct 20 '22 17:10 daosbuild1

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10556/6/execution/node/1083/log

daosbuild1 avatar Oct 20 '22 18:10 daosbuild1

The failing tests are unrelated IOR issues, and are being seen in other PRs. The ticket where these issues are being resolved: https://daosio.atlassian.net/browse/DAOS-11936

kjacque avatar Oct 20 '22 19:10 kjacque