daos-stack
DAOS-623 build: Add SCONS_ENV option
Allow one to propagate external environment with SCONS_ENV=user
Required-githooks: true
Signed-off-by: Jeff Olivier [email protected]
Bug-tracker data: Ticket title is 'Generic ticket for minor code cleanup and improvement' Status is 'Resolved' https://daosio.atlassian.net/browse/DAOS-623
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
LGTM, and even wonder if the default should be
user. Though that would change the default behavior
I just modified it...Let's see what happens in CI with the different default.
Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10432/2/execution/node/450/log
Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10432/2/execution/node/356/log
Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10432/3/execution/node/449/log
Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10432/3/execution/node/355/log
There's also https://github.com/daos-stack/daos/blob/master/SConstruct#L331-L338 to look at as well.
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-10432/5/execution/node/1137/log
What's left to do with this one? FWIW, SCONS_ENV=full works for my purposes on Frontera, where gcc, cmake, and some others are in non-standard paths.
For what it's worth I've found out how to do this with .files in a users home directory if that would be preferable.
For what it's worth I've found out how to do this with .files in a users home directory if that would be preferable.
I'd rather have an option than define something external before building. But what is the general flow of doing this with .files?
For what it's worth I've found out how to do this with .files in a users home directory if that would be preferable.
I'd rather have an option than define something external before building. But what is the general flow of doing this with
.files?
The page I was working from is this one. https://steelpangolin.wordpress.com/2014/02/06/modifying-scons-environment-variables-globally/
The page I was working from is this one. https://steelpangolin.wordpress.com/2014/02/06/modifying-scons-environment-variables-globally/
As simple as that approach is, I think this PR is less error-prone
@jolivier23 @ashleypittman Could we get an updated version of this PR, please? After the latest scons changes this check is now failing: https://github.com/daos-stack/daos/blob/aa64f5092d4c3b2107bd38c392c9a9437c322c33/SConstruct#L348-L349
@jolivier23 @ashleypittman Could we get an updated version of this PR, please? After the latest scons changes this check is now failing:
From @ashleypittman, we need init the PreReqComponent before the stdatomic check https://github.com/daos-stack/daos/blob/f99382ba1006ada422ab84d03a6808c38131c7d5/SConstruct#L347-L352
FYI that @ashleypittman this change in #11291. Maybe we can close this PR?
FYI that @ashleypittman this change in #11291. Maybe we can close this PR?
that PR is still a draft. this looks ready to land :-)
FYI that @ashleypittman this change in #11291. Maybe we can close this PR?
that PR is still a draft. this looks ready to land :-)
I'm fixing some other issues at the same time so it's still in testing.
For what it's worth both PRs add the SCONS_ENV option (I copied the code from here) however that option is still not enough to solve the initial problem however it is a step forwards.