Daniel T

Results 160 issues of Daniel T

We can DRY out by using must subscribe https://github.com/dymensionxyz/dymint/blob/df608b57937e7594503f0507b78c04c3ab05f4de/block/synctarget.go#L15-L47 https://github.com/dymensionxyz/dymint/blob/1886e18d788b9b2745b1989a472084985578a147/utils/event/funcs.go#L15-L41

https://github.com/dymensionxyz/dymint/blob/af508133afe7acd0db5f4abaea9ea79720fbcbad/types/metrics.go#L13-L16 > art: this metrics is not reliable, there are a subset of nodes that show 0 for the hub_height

When using buffered channels the subscription gets cancelled if the channel gets full We need to decide on a solution See https://github.com/dymensionxyz/dymint/pull/773 for discussion and context cc @omritoptix

``` Getting Celestia extended headers via RPC call[] module=celestia panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x28 pc=0x106ff51a8] goroutine 70 [running]: github.com/dymensionxyz/dymint/da/celestia.(*DataAvailabilityLayerClient).getDataAvailabilityHeaders(0x14000bfe0f0,...

We have unnecessary branching in our code because we, currently 1) On receiving a gossiped block, we apply it or add it to cache (https://github.com/dymensionxyz/dymint/blob/7c1978553888786898df49467fda781c1fcf1b62/block/manager.go#L242-L253) 2) On syncing from DA,...

## Description ---- Closes #XXX **All** items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up...

dym-internal

## Description ---- Closes #XXX **All** items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up...

security

- https://github.com/dymensionxyz/dymension/pull/787 - https://github.com/dymensionxyz/rollapp-evm/pull/131 - https://github.com/dymensionxyz/dymint/pull/621 - https://github.com/dymensionxyz/cosmos-sdk/pull/2 - https://github.com/dymensionxyz/iavl/pull/1 (see [here](https://github.com/rollkit/iavl/compare/deepsubtrees_0.19.x...dymensionxyz:iavl:danwt/deepsubtrees_0.19.x-extension) for diff with celestia's work) - https://github.com/dymensionxyz/cometbft/pull/2 ## old stuff for reference - Michaels EVM changes https://github.com/dymensionxyz/rollapp-evm/compare/main...feat/fraudproofs (see...

# PR Standards ## Opening a pull request should be able to meet the following requirements -- PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A --- Close https://github.com/dymensionxyz/dymint/issues/1009 For Author: - [ ] Targeted...

dym-internal