webdiff

webdiff copied to clipboard

Diffing minimized JSON files is annoying. If webdiff detects that a JSON file is a single, long line, it would be helpful if it offered to diff the pretty-printed versions...

danvk

The diffhunk selection from #200 is functional but leaves a bit to be desired: - Deleted diffhunks show a selection line both above and below the diffhunk (should only be...

danvk

It's pretty magical to see all those `useMemo` calls disappear! There's still some need for `useCallback` when a function gets passed to a `useEffect`.

danvk

This isn't a great use of space!

danvk

Style expanded skip lines differently

1

I like how pullrequest.com handles this. When you click a link to show more context, that additional context gets a gray background color. This keeps it visually distinct from the...

danvk

Here's webdiff now: "Show 228 more lines" is clear, but the up/down arrows are not. Here's pullrequest.com, by comparison: Here's how Reviewable handles it. I find this extremely clear! Including...

danvk

I believe that generating diffs is quite fast, but generating the UI for them may not be. For example, run: git webdiff 52aa15f^..52aa15f from https://github.com/danvk/codediff.js and click through to `package-lock.json`....

danvk

It's used in a somewhat complex way, primarily by `githubdiff.py`. Replacing it with direct use of the GitHub API would allow me to drop the dependency on `requests`.

danvk

webdiff supports showing PR diffs, but not a single commit. This would be a nice feature to have.

danvk

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.5 to 6.5.7. Commits 3e46a48 6.5.7 accb61e lib: DER signature decoding correction 03e06e1 6.5.6 7ac5360 Merge commit from fork See full diff in compare view [![Dependabot compatibility...

dependabot[bot]