dantleech

Add generic suport for ArrayAccess

``` /** * @return Generator */ ``` is generated where the 4th and 5th values can be null, instead it should combine the nulls into a nullable type. also, in...

Files with CRLF endings cause incorrect cursor position

10

Seems like there is indeed a bug in how phpactor locates the cursor. Given the following file: ```php

Support `empty` ``` $key = array_shift($keys); if (empty($keys)) { return $form->transformInput($key, $value); ```

Completion prioritisation

3

Following on from #516 - Project completions are still not prioritised - Completions for names imported into current scope should have highest priority

Fatal exception when creating a new class in a non-composer mapped directory

2

``` [Error - 13:13:45] Request workspace/executeCommand failed. Message: Exception [RuntimeException] There are no class name candidates Code: -32603 #0 /home/daniel/www/phpactor/phpactor/vendor/phpactor/language-server-phpactor-extensions/lib/LanguageServerCodeTransform/LspCommand/CreateClassCommand.php(67): Phpactor\ClassFileConverter\Domain\ClassNameCandidates->best() #1 /home/daniel/www/phpactor/phpactor/vendor/phpactor/language-server/lib/Core/Command/CommandDispatcher.php(51): Phpactor\Extension\LanguageServerCodeTransform\LspCommand\CreateClassCommand->__invoke() #2 /home/daniel/www/phpactor/phpactor/vendor/phpactor/language-server/lib/Handler/Workspace/CommandHandler.php(40): Phpactor\LanguageServer\Core\Command\CommandDispatcher->dispatch() #3 /home/daniel/www/phpactor/phpactor/vendor/phpactor/language-server/lib/Core/Handler/HandlerMethodRunner.php(86): Phpactor\LanguageServer\Handler\Workspace\CommandHandler->executeCommand()...

The indexer should passively remove references to invalid files from the index, but this doesnt currently seem to be the case, this results in: ``` $references = $this->client->class()->referencesTo($fromClass); ``` returning...

``` Starting language server, use -vvv for verbose output [Error - 14:15:51] Request textDocument/definition failed. Message: Exception [InvalidArgumentException] Do not know how to create class from type "NULL" Code: -32603...

Something like: ``` class BaseCLass { const FOOBAR = 'bar'; } interface SomeInterface { const FOOBAZ = 'foo'; } class Concrete extends BaseCLass implements SomeInterface { publci function baz() {...