dantleech
dantleech
Are you using the latest (master) version of Phpactor?
I think this is rather a recent regression which could be fixed in https://github.com/phpactor/phpactor/pull/1861. I'm going to close this as the code has changed significantly since I raised this issue....
I wonder if we should jump to constructor/invoke on the parenthesis
ah, i didn't realise it could return multiple, currently we manually ask the user to disambiguate for aggregate types: https://github.com/phpactor/phpactor/blob/63fdd994d58a421c5a94b84cf314efc3604999a1/lib/Extension/LanguageServerReferenceFinder/Handler/GotoDefinitionHandler.php#L77-L82
but yeah, let's figure out how other servers / IDEs solve this, and it fits into the bigger "find references to __invoke" picture.
if you really want to disable it completely, [here](https://github.com/phpactor/code-builder/blob/master/lib/Adapter/TolerantParser/Updater/UseStatementUpdater.php) is the place. i can't imagine supporting fully qualified / relative names any time soon, as it's an extreme edge case...
what should happen here? if we don't provide completion it looks like a bug, if we do it does say it's private.
No I think I ran into the same thing myself.
See https://github.com/phpactor/phpactor/issues/1162 You can use the `TolerantQualifiednameResolver` instead to get the FQN of the use
I think this issue is not required anymore, but there are still issues with renaming traits members vs. aliases which I'll look at.