Daniel Xu

Results 429 comments of Daniel Xu

I'll take a look. But it might be a few days before I get a chance.

Hi, thanks for the PR. Could you please describe more `strstr()`'s semantics? Will it match substrings? eg. `strstr("two", "onetwo") == 1` ? I'm also getting a segfault when I try...

@liutingjieni I think strstr() on two constant strings still makes sense. For example, consider positional parameters: ``` $ sudo ./build/src/bpftrace -e 'BEGIN { $r = strstr("one", str($1)) }' "onetwo" [1]...

I think it worked at one point. pkgs.org reports a novendor version being shipped in fedora: https://pkgs.org/search/?q=libbpf-sys I also seem to recall dynamic linking with libbpf working at some point...

> > I prototyped a frontend which allowed you mark up a diff to leave comments, and that seemed fairly promising. The workflow ends up being similar to a the...

FWIW you will no longer need debug syms (really just symbols) after the next release. See https://github.com/iovisor/bpftrace/pull/2264

Does the non-stripped binary work? Also, can you capture the `perf_event_open()` syscall args and put the results here? Here's the invocation that displays all the args: ``` # strace -e...

So I suspect there's some funniness here: https://github.com/iovisor/bpftrace/blob/f32831c70b5e714bc7755257b0cc1935f7534d91/src/attached_probe.cpp#L474-L500 Not sure I have time anytime soon to get in and debug it. Maybe you could do some printf debugging and figure...

@caizixian can you give the linked PR a try please?