dannagle
[BUG] Light mode coloring needs improvement
I personally use Dark Mode everywhere, or I would've caught this earlier.
The rendering of some of the UI elements with Light Mode could use some improvements. There are a few areas where Dark Mode coloring is bleeding through because the light mode section is undefined.
I confirm the problem using Windows portable versions of the software. This is what happens when I click row number 2 in 8.8.9 version:
and what in the latest 8.9.1:
I think the problem could be related to the new feature "Upgraded Qt libraries (now using Qt 6.9)".
Giacomo
Thanks for the screenshot. That made it clearer for me as mine does not quite look like that. The fix is pushed (hover and selected row is now shows a light yellow), though I still need to check it on Mac before I close this.
As much as I love Dark Mode, I need to leave at least 1 one development computer on Light Mode so I can catch these problems earlier. Your Qt 6.9 theory seems likely.
I mostly use PacketSender with light theme and I've observed these issues.
A related issue I just experienced is that when switching from light -> dark the GUI is stuck in some weird intermediate state:
(Not all apps support switching theme during runtime of course, and restarting PacketSender fixes this issue. I've started using https://learn.microsoft.com/en-us/windows/powertoys/light-switch to set light/dark theme based on time of day and it's a really nice experience when apps switches automatically)
I actually know the fix for that one.
It requires a polling thread to check if the system switches from light/dark. Once noticed, the correct style can get loaded. Not a big deal. It has just not been a priority since like you said a restart can fix it.
I think the problem is more than that. Regardless of the state of the computer, restarted or not, I've the problem. I think that there is a problem loading the colors style from the windows theme and if there are something manually changed.
If you like, I can try beta versions in order to check if the problem has been solved.
Giacomo
I will happily accept any beta testing! Contact me: hello AT packetsender.com and reference this issue ticket (number 400).
A beta will be a couple weeks. Screenshots of the problem areas is the best help right now. I think a full light mode style like that was made for dark mode is the best fix, but that will have to wait until later. To get something out sooner, I can target just the light mode problem areas. Full light style can then be a follow-up release.
What I've forgotten to write is that I'm using the portable version of Packet Sender.
Giacomo