added clang-tidy CI job and fixed warnings / added CMake option "DISABLE_CPP03_SYNTAX_CHECK" / CMake cleanups

Open firewave opened this issue 3 years ago • 2 comments

The only interesting suppress warning is currently clang-analyzer-core.NullDereference since it depends on very complex value flow, might be a false positive and I didn't have the time to review it.

Mar 10 '22 19:03 firewave

@danmar This should be fine to merge now.

Apr 11 '22 09:04 firewave

I disabled performance-inefficient-string-concatenation since that warning appears to have false positives - see https://github.com/llvm/llvm-project/issues/54526. I was always curious about this warning but never had the time to properly look into it.

Apr 11 '22 09:04 firewave

This is ready for review again. I also updated and modernized the clang-tidy job.

Aug 23 '22 11:08 firewave