cppcheck run selfchecks with `rules/token-matching.xml`

Jun 01 '24 18:06 firewave

Either the rules significantly slow down things or we had a big performance regression which slipped by me...

Jun 01 '24 19:06 firewave

@chrchr-github So what do we do with this now? IMO it would be nice if do not require a specially build binary to perform the internal checks. If we cannot (or are not) using the rules how do we expect the user to.

Jun 03 '24 08:06 firewave

I guess it was intended to allow developers to check their code without having the CHECK_INTERNAL flag set. But the CI does that anyway. @orbitcowboy Do you actually use this rule file?

Jun 03 '24 08:06 chrchr-github

I guess it was intended to allow developers to check their code without having the CHECK_INTERNAL flag set. But the CI does that anyway. @orbitcowboy Do you actually use this rule file? Thanks for asking! Since CI does it anyway, I have no special local use case.

Jun 03 '24 12:06 orbitcowboy

So I would say we should get rid of it.

Jun 03 '24 13:06 chrchr-github

error-reporting.xml can also be removed.

The remaining ones might also be obsolete or should be used in the selfchecks. Even if those are meant to be examples they should at least be tested.

Jun 10 '24 11:06 firewave

Closed in favor of #6951.

Oct 24 '24 00:10 firewave