Instagram-API icon indicating copy to clipboard operation
Instagram-API copied to clipboard

Creating a file for python shims

Open qsniyg opened this issue 8 years ago • 1 comments

There's a lot of places in the code where php->python shims are duplicated (simple example being Image.open(photo).size[0] to represent getimagesize(photo)[0], and a more complicated example would be the md5 functions), so I was wondering if creating a separate file to hold all those functions might be more efficient, and make the code look closer to the PHP counterpart.

qsniyg avatar Feb 28 '17 12:02 qsniyg

Hello, Hopping you've gone though the contribution guidelines and understood why the code pattern is as it is even though it hurts

If it will be encapsulating whole PHP functions and just return the same API as the PHP then its okay, i had started on something like that, you can take a look at https://github.com/danleyb2/Instagram-API/blob/master/InstagramAPI/src/Utils/php.py

I never wen't ahead since it took out project folder structure similarity

I give you a go ahead, i could gladly merge a PR on that,

Thank you

danleyb2 avatar Feb 28 '17 21:02 danleyb2