Ash Jones
Ash Jones
I don't really have much to add but It compiles and runs fine 😅
I don't think it would be too hard to add this to the other resources
So I thought I'd start approaching this from where @xavpaice mentioned. swapping out where we load the support bundle from a file with a loop over the cli arguments using...
so my first stab at this is available in https://github.com/replicatedhq/troubleshoot/tree/danj-multiple-inputs naming conventions are open to suggestion.
I'm now at a place where I'd want to start discussing with @diamonwiggins how to integrate our changes. The current structure of collectors makes it unweildy to check for collector...
@chris-sanders nope, I only picked those as an example. when I get around to tidying this up and resolving the requested changes, I can remove these
TODO: - [x] handle non-namespaced resources - [x] add tests
> Hey there, this review has been pending for a bit, and I've meant to make a comment for a while. I'm wondering if we want to move the "bring...
https://github.com/replicatedhq/troubleshoot/pull/780 has been merged in, giving us the findResource function, and an example clusterResources analyzer. The clusterResources analyzer itself is capable of simple yaml comparison, and should be enough to...
hmm, I don't think I want to change the bundle structure itself, just where it's defined. so for example, instead of saying `output.SaveResult(c.BundlePath, "cluster-resources/namespaces.json", bytes.NewBuffer(namespaces))` we can, for example (not...