pyzipper icon indicating copy to clipboard operation
pyzipper copied to clipboard

Tests fail on Python 3.13

Open wRAR opened this issue 1 year ago • 5 comments

test/support/__init__.py:19: in <module>
    import nntplib
E   ModuleNotFoundError: No module named 'nntplib'

nntplib was removed from Python in 3.13.

wRAR avatar Oct 06 '24 11:10 wRAR

I think that the nntplib was just copy/paste code from older stdlib

I have created a PR that fixes this and enable more tests

https://github.com/danifus/pyzipper/pull/39

Andrey, if you have time, please take a look and let me know what do you think.

adiroiban avatar Jul 07 '25 22:07 adiroiban

Thanks! The nntplib part looks fine to me and matches the Debian patch for this issue.

wRAR avatar Jul 09 '25 18:07 wRAR

I kind of gave up on pyzipper. The base code is old... and the repo wasn't updated in the last 3 years.

I am trying a different approach without copying the stdlib base code

I am trying to get the minimum code in stdlib to make projects like pyzipper much easier to maintain and share code

adiroiban avatar Jul 17 '25 10:07 adiroiban

That's a good idea. I initially tried to get some of this upstreamed but it stalled: https://github.com/python/cpython/issues/81719 (probably because it ended up being a giant PR)

I haven't had time to look at this repository much lately but have always liked the idea of simplifying the maintenance by making it easier to modify stdlib's zipfile. Happy to help you get these changes into cpython

danifus avatar Jul 18 '25 00:07 danifus

Thanks Daniel for the cpython help. Much appreciated.

Regarding pyzipper, there is PR #39 waiting your review :)

I wanted to get all the tests running on Windows / Linux / macOS to be used as the base for future changes.

I don't know if I will continue to work on pyzipper... as using cryptography is kind of a hard requirement for me.

But maybe we can find a way to have pyzipper with cryto operations implemented using both PyCryptodome and cryptography.

I am not happy to have to create a separate project for WinZip AES.

For me performance is not important.

adiroiban avatar Jul 18 '25 09:07 adiroiban