pvtrace

pvtrace copied to clipboard

Triangular Prism Geometry for LSC

20

Hi Daniel, Firstly just wanted to say thanks a million for the work you've done on this code, the software is very impressive and easy to follow for a beginner...

tommyflynn13

The use of np.float and np.int is deprecated (see [numpy docs ](https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations))

dcambie

Enable support for Py3.8 and 3.9

1

Passes CI 3.7/3.8/3.9 linux/mac/win, personally tested 3.9.4 on Windows and 3.7.9, 3.8.5 3.9.1 on Linux. Enabled by upstream fix rdeits/meshcat-python#78 released as 0.1.0 and probably other upstream changes

dcambie

Add new test `test_parse_simple_box2_yml()` with more object types, and fix error in parsing of spectra in `parse_absorber `and `parse_scatterer` highlighted by new test.

dcambie

Move visualization properties from visualizer to Nodes

6

For many PvTrace simulation it would be nice to be able to add node visualization properties, such as color transparency etc. However, currently, the only visualization options (wireframe, transparency, opacity...

dcambie

build from source fails

19

I did `python3 setup.py build`, but then `python3 setup.py install` fails on this step: ` Running Rtree-0.9.4/setup.py -q bdist_egg --dist-dir /tmp/easy_install-_ns3zuje/Rtree-0.9.4/egg-dist-tmp-xpt3goi2` > AttributeError: python3: undefined symbol: Error_GetLastErrorNum This is on...

keithbriggs

Some notes to self on documentation topics ### 1. Simulating large-scale scenes Units can be a problem here as we find EPS_ZERO gotchas ### 2. Problem with linear background models...

danieljfarrell

Issues with numpy threading and multiprocessing

1

I've run your script a few times on different setup. Interestingly, I obtained different results :) The main reason is that numpy already has some multi-threaded function (and it spawns...

danieljfarrell

Light mask functions slightly inconsistent with geometry sizes

3

There is a _slight_ inconsistency between the Light mask functions, e.g. cube_mask vs geometry.Box Calling Box(X,Y,Z) creates a box with sides of length X, Y, and Z respectively. Calling pvtrace.light.light.cube_mask(X,Y,Z)...

peter-spencer

Refactor custom surface properties using facets

1

Surface reflection is currently handled with a delegate object approach. A node owns a geometry, the geometry owns material, the material owns a surface object, the surface object owns the...

danieljfarrell