python-betterproto icon indicating copy to clipboard operation
python-betterproto copied to clipboard

Ensure any fields that could intersect with Message are renamed

Open Gobot1234 opened this issue 4 years ago • 3 comments

Follows from a conversation with @danielgtaylor. THIS IS A BREAKING CHANGE

parse -> parse_ serialized_on_wire -> serialized_on_wire_ foo -> foo

This allows us to reserve names for betterproto. I'll need to document this somewhere.

Gobot1234 avatar Jan 18 '22 21:01 Gobot1234

Which part of this is breaking? The change overall seems fine to me.

cetanu avatar Jan 27 '22 22:01 cetanu

I removed the which_one_of and serialised_on_wire methods

Gobot1234 avatar Jan 27 '22 22:01 Gobot1234

I see... and they are attributes on the messages instead... That seems like good value in my opinion

cetanu avatar Jan 27 '22 22:01 cetanu