workflow-core icon indicating copy to clipboard operation
workflow-core copied to clipboard

Try-catch clause

Open kirsanium opened this issue 5 years ago • 8 comments

Feature introducing complex error handling via new StepBuilder's methods Try() and Catch(). This works pretty similar to CompensateWith() and is based off of that, but with no reversion and it allows to catch exceptions by type. Also introducing WorkflowDefinitionValidator to ensure that there are corresponding catches for every try.

kirsanium avatar Feb 25 '20 10:02 kirsanium

Going to be travelling for a few weeks but I'll try take a deeper look soon.

danielgerlag avatar Mar 07 '20 03:03 danielgerlag

Just wanted to say I didn't forget about PR, going to fix the issues you noticed some time soon.

kirsanium avatar Apr 15 '20 13:04 kirsanium

@kirsanium I haven't forgotten about this PR. I will try carve out some time in the next week or so to dive deeper into it but on the surface it looks really good!

danielgerlag avatar Jul 11 '20 15:07 danielgerlag

@danielgerlag @kirsanium Any news on this? Would be very handy to have this in the product.

knoxi avatar Sep 11 '20 12:09 knoxi

@knoxi waiting for the review from @danielgerlag

kirsanium avatar Mar 04 '21 18:03 kirsanium

@danielgerlag any news on that? It's now open since a year.

knoxi avatar Mar 08 '21 15:03 knoxi

@kirsanium Do you see any chance to update the branch and extend the tests? It would be really great if the feature will be part of the library!

knoxi avatar Nov 23 '21 08:11 knoxi

Sorry I have no time and interest in this one since too much time have passed - I haven't even coded in c# for some time now...but please please finish this one, it was goddamn ready two years ago

kirsanium avatar Jun 20 '22 18:06 kirsanium