Remove CancellationToken from writing persistence operations
Describe the change
Removed the CancellationToken parameter from all writing persistence operations. This prevents cancelling workflows or stopping the host from cancelling writing persistence operations and thus losing data.
Fixes #953 Fixes #1032
Describe your implementation or design
Removed the CancellationToken parameter from all writing persistence operations.
Tests
Yes. I reproduced the issue by adding a StopScenario for persistence providers. After the change, this scenario passes.
Breaking change
Yes. Removed CancellationToken parameter from multiple public methods.
Here is an alternative, less invasive approach: https://github.com/danielgerlag/workflow-core/compare/master...mamidenn:workflow-core:fix-race-condition-on-stop-min
Here is an alternative, less invasive approach: master...mamidenn:workflow-core:fix-race-condition-on-stop-min
Yes, I like this approach better ^
Yes, I like this approach better ^
Closing this in favor of #1081 then.