Daniel Bower
Daniel Bower
The components in a job are simply spring beans that are loaded into the global Grails (Spring) context. Looks like we could provide this feature by using AutomaticJobRegistrar (from http://docs.spring.io/spring-batch/2.2.x/reference/html/configureJob.html)....
Shared bits are handy, it means you can access any bean/service in your app. I believe the AutomaticJobRegistrar ought to allow access to everything in the parent context, but nothing...
While this works, I'm increasingly convinced that the correct way to do it is a separate module so that the dependency list in the pom is correct in both instances.
Reasoning for the separate module: https://www.mail-archive.com/[email protected]/msg139854.html
Are there any suggestions or concerns with this PR that would increase its chances of being merged?
If you REALLY prefer to shade, then you should be prefixing those packages so they don't conflict with the rest of the app. See this feature of the maven-shade-plugin: https://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html
I'd recommend that if you wanted to stick with just one artifact, you go with the non-shaded version. That will remove some complexity and make the library more secure. If...