danielcranney
Light Screen Icons
I have a question and an inquiry. When I am in light mode, some icons are missing, but everything appears fine in dark mode. Did I set something up incorrectly, or is this a feature that doesn’t exist yet?
Which icons are missing? I've just tried this myself at 3fc3595593bc992e6febba6580d6c9571f5e625f using npm run dev and didn't encounter any issues with icons.
In dark mode, they all appear
Icons missing: Next JS, Babel, Django, XD and Git hub
Are you hosting the project yourself in a dev environment, or using the production version at profileme.dev?
There seems to be a link between how the project is deployed and how some image links are generated, at least for the social ones. I'm still getting familiar with how it works.
I see the issue you're experiencing now, it isn't that the social icons are missing (that's another issue), but instead it's the fact that the markdown content only generates for one colour-scheme for skill icons based on whether you choose light or dark mode in the preview. If you choose dark mode in the profileme.dev preview, then apply to github and set your preference to light mode, some icons will be indistinguishable from the background.
It does the correct behaviour for the socials where it includes the <source media="(prefers-color-scheme: dark)" tags, so we'd need to do something similar for skill icons where the path/darkPath attributes are set.
Light mode on github:
Dark mode on github:
I've just pushed a PR to address the issue. Not sure how long it will take to get reviewed and accepted, but you can deploy manually to get the output now if you need to.