mocker-data-generator icon indicating copy to clipboard operation
mocker-data-generator copied to clipboard

Fix broken / hijacked faker.js dependency 🐛

Open dimorphic opened this issue 4 years ago • 1 comments

Issues solved in this PR:

  • [x] [deps] Lock faker-js version to a previousnot hijacked version (repo is dead: https://github.com/marak/Faker.js/)
  • [x] [dist] Commit build dir so this can be installed from Github / locally and use the build files

Later to do:

  • [ ] Replace faker with community stable version: https://github.com/faker-js/faker instead of locked pre-hijack ?
  • [ ] Remove build dir once merged back into main package and republished to npm as stable?

@danibram Thanks for the package! 👋

dimorphic avatar Feb 03 '22 17:02 dimorphic

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

ghost avatar Feb 03 '22 17:02 ghost

Hi, I released a new version removing the generators from the package, so this is no longer needed ( I hope =) ). Thanks for your contribution anyway

danibram avatar Dec 30 '22 01:12 danibram

@danibram 👍🎩

dimorphic avatar Dec 30 '22 07:12 dimorphic