php-docblock-checker icon indicating copy to clipboard operation
php-docblock-checker copied to clipboard

Opinionated support for ?thing params

Open tomsowerby opened this issue 6 years ago • 0 comments

Current behaviour encourages

/**
 * @param string $thing
 */
function doStuff(?string $thing) { ... }

I think that it should be:

/**
 * @param string|null $thing
 */
function doStuff(?string $thing) { ... }

When the ? is present, the type is nested, with the parent type being NullableType. We deal with this already on line 156 and extract the name of the child, so we can hook into this further to add the '|null' if we have this parent/child combination.

This one might be a bit opinionated, so happy to discuss more...

tomsowerby avatar May 15 '19 07:05 tomsowerby