Xiaochao Dong

Results 129 comments of Xiaochao Dong

[#2474](https://github.com/prometheus/alertmanager/issues/2474) could be the case.

@roidelapluie @simonpasquier @w0rm Please take a look in detail.

@simonpasquier I have added test cases for this issue, the main branch will fail the test: ``` gotest -v -race -run TestDispatcherReceiveAndNotifyRepeatedResolvedAlerts === RUN TestDispatcherReceiveAndNotifyRepeatedResolvedAlerts === RUN TestDispatcherReceiveAndNotifyRepeatedResolvedAlerts/repeated_alerts_after_aggrGroup_deleted dispatch_test.go:743: unexpected...

`Retry-After` doesn't support duration less than one second, this is hard since we may overload our service or lose some tokens..

@alvinlin123 Somehow I have forgotten this patch. Please take another look.

@yeya24 There are two changes: 1. add Retry-After header to the existing 429 responses. 2. change a part of 429 response to 413 since those requests contain too many samples,...

We only reject incoming requests for v1 chunk storage, I think we should do it for v2 block storage as well.

I think you should open another issue to request renovate to add those empty spaces as well. Anyway, you can use `sed -i 's/ == /==/' requirements.txt` to remove those...

@velis74 Pull request welcome! You can start from [here](https://github.com/damnever/pigar/blob/master/pigar/reqs.py#L24).