puppet-puppetexplorer icon indicating copy to clipboard operation
puppet-puppetexplorer copied to clipboard

Nginx support instead of Apache

Open dvandendaele opened this issue 11 years ago • 3 comments

Hello ,

I would like to use Nginx instead of Apache in the manifest file of your module. Could you make this change ?

dvandendaele avatar Oct 17 '14 12:10 dvandendaele

A general suggestion to manage this (as any other resources that is not directly related to the software installation): expose a parameter that let the user override the class where these extra resources (webserver to use, repos to manage or whatever is provided by third modules). In this case it could be something like: $webserver_class = 'puppetexplorer::apache' # The module's default then either provide a puppetexplorer::nginx class to be used as alternative or leave the choice to the module's users. Same thing might be used to manage repos, instead of the booleans manage_yum and manage_apt: $repo_class = 'puppetexplorer::repo'

my2c

alvagante avatar Oct 17 '14 20:10 alvagante

+1

mkrakowitzer avatar Dec 23 '14 08:12 mkrakowitzer

That issue can be closed:

# [*webserver_class*]
#   Name of the class where the webserver is configured
#   Default: '::puppetexplorer::apache'

https://github.com/spotify/puppet-puppetexplorer/commit/9c6bf2692c05784886f8fccc00184badeb03266c

roidelapluie avatar Jan 04 '16 12:01 roidelapluie