svlint icon indicating copy to clipboard operation
svlint copied to clipboard

Fix crash in style_keyword_0or1space

Open Timmmm opened this issue 8 months ago • 3 comments

The parser can return Keyword for "dpi-c" (including the quotes), which was not being matched by the re_split regex.

This fixes the regex, adds this case to the test, and removes the unwrap so that it doesn't crash the whole linter if there's another mistake in the regex.

Timmmm avatar Jun 17 '25 14:06 Timmmm

Fixes https://github.com/dalance/svls/issues/346 (I reported that in the wrong repo; oh well).

Timmmm avatar Jun 17 '25 14:06 Timmmm

I found your name is not added to contributors list yet. Could you add it, and fix CI failure?

dalance avatar Jun 19 '25 00:06 dalance

Updated. I guess there's a slight issue in that the testcases are used both as tests and as examples in the manual. I added "DPI-C" to it because I want to test that case (because it previously caused this crash), but I don't think it's really relevant for the example.

Maybe there needs to be a way to exclude test cases from the manual? Not a big deal for now anyway.

Timmmm avatar Jun 19 '25 08:06 Timmmm

Any chance this could be merged?

Timmmm avatar Jun 30 '25 13:06 Timmmm

Sorry, I missed it.

dalance avatar Jun 30 '25 14:06 dalance