Naoya Hatta

Results 272 comments of Naoya Hatta

I checked this version again, and found some corner cases. Could you check it? ```rust let tests = [ ("MIT OR Zlib OR Apache-2.0", "Apache-2.0 OR MIT OR Zlib"), (...

I checked #79. I think using spdx instead of the ad-hoc normalization logic is a correct way, but `spdx::Expression::canonicalize` doesn't sort license order. Sorting seems to be necessary to normalize...

Looks good! If you open a PR, i can merge it.

I checked the issue. Do you mean that `procs ` don't show anything? If so, this is expected behaviour because procs takes arbitrary string for process filtering as argument. If...

Is there any reference implemetation which have such feature?

Do you know how `bundle` gets author's information which should be embedded in license file?

I profiled a large project, and found time of table construction is not dominant. So the following step will improve performance. * Move `create_type_dag` to post_pass1. Probably it can be...

I think `genvar` is clearly constant variable, but wonder whether loop variable is constant or variable. In the following code, the value of `i` at each loop is fixed at...

> I think Veryl should treat a loop variable as a variable except when it is referred as a reset value. I think this rule is bit difficult, and may...