Daniel King
Daniel King
Closing as stale. Please open a new issue if you are still encountering problems.
@knighton or @karan6181 what do you think?
Thanks for this @ashishdatta ! We will take a look shortly :)
Closing as this notebook has now been removed.
I mostly meant, for that one thing where you forgot the parenthesis for the functions, did we have a test that would've caught that issue?
The composer `Trainer` accepts an arbitrary `train_dataloader`, so I'm not sure what you mean here. Could you please clarify?
Ah, got it! The code actually does automatically download from object store (https://github.com/mosaicml/composer/blob/ff59e862b92a7a1e62f72b57e36f528eb2c4bdfa/composer/datasets/in_context_learning_evaluation.py#L333), and the ICL classes expect the data to be in a particular format that probably isn't super...
Makes perfect sense @buddha314, I'd be happy to accept a PR doing this!
Makes sense, I might consider making a new `LocalLinkerPaths` that reads from environment variables.
ahh, the config parameter is called `linker_name`, not `name`. If you set `linker_name` instead, it should work.