setup-nox icon indicating copy to clipboard operation
setup-nox copied to clipboard

Nox itself isn't installed in the newest Python version

Open d-k-bo opened this issue 3 years ago • 3 comments

Nox is currently installed using Python 3.9.12 even if 3.10.4 is available.

Take, for instance, the log of the self test of this repository:

Available CPython versions: [ '2.7.18', '3.10.4', '3.6.15', '3.7.13', '3.8.12', '3.9.12' ]
[...]
Nox itself will be installed using 3.9.12

I guess this happens because it is assumed that the last version is the newest one, but that's unfortunately no longer true since Python 3.10.

Thank you for your work on this project!

d-k-bo avatar May 20 '22 15:05 d-k-bo

Thanks so much for the report <3

hmm, it looks like findAllVersions just returns them sorted lexicographically, which just coincidentally happened to be correct until 3.10 dropped.

I'll probably tackle this by sorting the versions using a semver parsing library (technically python doesn't actually use semver, I don't think, but it'll work for released versions at least), which should be pretty straightforward. If anyone wants to have a crack at it before I get a chance to and pop up a PR, be my guest :)

daisylb avatar Jun 01 '22 02:06 daisylb

Just started using setup-nox myself, bumped into this one, and had a go at fixing it: #437

scop avatar Feb 02 '23 23:02 scop

Hi @daisylb , et al. Is this repo still being maintained? I ask because it looks like this issue is still waiting to be merged, and I see no conflicts with it. I would like to use this action, but not if it has no maintainers. Happy to help where needed, but I don't want to become the maintainer.

lazarillo avatar Sep 01 '23 12:09 lazarillo