node-gcstats icon indicating copy to clipboard operation
node-gcstats copied to clipboard

updated node-pre-gyp and other dependencies

Open sumeetkakkar opened this issue 4 years ago • 4 comments

This is to fix security vulnerabilities in the bundled version of node-pre-gyp.

Removed node-pre-gyp from bundledDependencies based on updated recommendation in https://github.com/mapbox/node-pre-gyp/#1-add-new-entries-to-your-packagejson

Note: in the past we recommended putting @mapbox/node-pre-gyp in the bundledDependencies, but we no longer recommend this.

This should support Node.js version >=10, and can optionally be released as semver major.

https://github.com/dainis/node-gcstats/issues/56 https://github.com/dainis/node-gcstats/issues/42 https://github.com/dainis/node-gcstats/issues/59

sumeetkakkar avatar Nov 01 '21 23:11 sumeetkakkar

@dainis Can you please see if this PR can be merged, and new version of gc-stats released? The new dependencies support Node.js Version 10+, and we are fine if the new release is SEMVER major.

sumeetkakkar avatar Nov 02 '21 19:11 sumeetkakkar

This would be great. I just noticed issues with https://github.com/sematext/spm-agent-nodejs that seem to be caused by this. A new gc-stats release would be great, @dainis !

otisg avatar Nov 02 '21 22:11 otisg

@sumeetkakkar also maybe look at https://github.com/adnanrahic/node-gcstats/pull/6 . This fork seems a little ahead.

otisg avatar Nov 02 '21 22:11 otisg

@sumeetkakkar also maybe look at adnanrahic#6 . This fork seems a little ahead.

Thanks!

sumeetkakkar avatar Nov 03 '21 21:11 sumeetkakkar