daily icon indicating copy to clipboard operation
daily copied to clipboard

[Bug] profile page layout shift when switching tabs

Open ted-dino opened this issue 2 years ago • 18 comments

Hi. I noticed an unusual behavior on the page while viewing my profile on the website. the active tab indicator jumps when I scroll down to the "Reputation" tab. i have attached a video to help explain it better. im not a native english speaker so sorry if i made some mistakes in my english :D

https://user-images.githubusercontent.com/84649871/233579569-848436cd-39fd-4673-aca7-075ccb68d7c3.mp4

ted-dino avatar Apr 21 '23 08:04 ted-dino

Hi @ted-dino thanks a lot for logging this, it does look to be a UI issue. Will log it for the team to solve, thanks for raising it.

rebelchris avatar Apr 21 '23 08:04 rebelchris

happy to help.

ted-dino avatar Apr 21 '23 08:04 ted-dino

@ted-dino thanks for reporting. We've opened this for contributors, let me know if you are keen on fixing this, I'd be glad to help you out 🥳

sshanzel avatar Apr 24 '23 15:04 sshanzel

no problem @sshanzel. Yes, I would love to help out and fix this issue.

ted-dino avatar Apr 24 '23 15:04 ted-dino

no problem @sshanzel. Yes, I would love to help out and fix this issue.

That's great to hear! I will carve out a plan and just fix the environment for you to be able to do the development then I will send you a message 🥳

sshanzel avatar Apr 25 '23 11:04 sshanzel

alright. looking forward to it

ted-dino avatar Apr 25 '23 12:04 ted-dino

Hi, I was going through the code. The bug is in the third-party library called flip-toolkit/lib/types. Looks like we have to fix it there first.

abdulqadeerqureshi avatar Apr 27 '23 08:04 abdulqadeerqureshi

After careful evaluation, we realized two things. One is we currently don't set the staleTime for the queries being used here. Second, one of the causes of the content shift is the unnecessary setting of state on /[userId]/index for the readingHistory data.

We are planning to fix the points above, though, at the end of the day, we will also apply a loading placeholder to avoid the content shift completely. Let me know if any of you is up for the challenge! 🚀

sshanzel avatar May 16 '23 10:05 sshanzel

@ted-dino, in light of the new information, are you still planning to have a go at this one?

killshot13 avatar May 22 '23 03:05 killshot13

hey! absolutely! sorry for the late response, but i am definitely up for it.

ted-dino avatar May 22 '23 04:05 ted-dino

@ted-dino let me know if you need further guidance 🥳

sshanzel avatar May 22 '23 08:05 sshanzel

thanks, will do @sshanzel

ted-dino avatar May 24 '23 13:05 ted-dino

Hi @ted-dino, I understand things can get pretty busy but I just wanted to check if you are still interested in working on this. If not it is totally cool but we will have to unassign it so we can free it up to those looking for things to fix.

sshanzel avatar Aug 08 '23 13:08 sshanzel

Hi @sshanzel . I apologize for the delayed response. I appreciate your understanding. Due to a new job commitment, I find myself rather occupied at the moment. If possible, could you kindly reassign the task from me? Thank you for your consideration.

ted-dino avatar Aug 10 '23 01:08 ted-dino

Hey @ted-dino, all cool. No worries at all. We understand everyone has their own set of priorities, and we were just checking up on the status updates.

sshanzel avatar Aug 10 '23 02:08 sshanzel

Sorry, I think I misunderstood. Let me un-assign the issue now.

sshanzel avatar Aug 10 '23 05:08 sshanzel

Hey there @killshot13, if you are still interested in contributing to this issue, feel free to let me know, so I can assign this to you 🚀

sshanzel avatar Oct 27 '23 10:10 sshanzel

Hey sure thing yeah I'll take a stab at it. Thanks @sshanzel

killshot13 avatar Oct 29 '23 02:10 killshot13

We revamped our profile page recently and this design is no longer applicable. Closing this issue as resolved, feel free to log any other issues 🙏

rebelchris avatar Apr 10 '24 11:04 rebelchris