daily icon indicating copy to clipboard operation
daily copied to clipboard

🐛 BUG: Sharing DailyDev posts to squads results in a no-name post with generic thumbnail

Open frank-connolly opened this issue 1 year ago • 2 comments

What went wrong? 🤔

  1. Saw a cool post on feed - "Become a Better Java Developer: 19 Tips for Staying Ahead in 2024"
  2. Clicked on it and used the option on the right to share it with group Just Java
  3. The post in the squad shows no text and generic thumbnail background image

Expected Behavior

I expected the post in the squad to look the same as the post in the feed with article name and relevant thumbnail

Steps to Reproduce Issue

1. Go to your feed
2. Click on a post
3. Share it with a squad using the options on the right
4. See the new post on the squad

Solution Proposed

I assume the share is sharing the daily dev post instead of the linked article

Screenshots

![DESCRIPTION](LINK.png)

Environment

No response

Browsers

Chrome

OS

No response

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • [X] I follow the conditions of this project.

frank-connolly avatar Oct 24 '24 08:10 frank-connolly

Ok so this seems to only happen sometimes. I just did it again and it worked. Perhaps there is some conditional logic or a failure when grabbing title and thumbnail under some conditions

frank-connolly avatar Oct 24 '24 08:10 frank-connolly

Hi @frank-connolly,

You're right. It should behave the same, maybe there's a glitch. Can you share the links to the original post and the squad post please?

idoshamun avatar Oct 27 '24 07:10 idoshamun

This happens to me reproducibly, when trying to share a link and choosing a post from history, which is inlined inside the box, where you would put in any link. It gets an api.daily.dev URL, rather than dly.to, where dly.to works fine.

The no title in this issue is the same as here.

Akkitto avatar Aug 21 '25 14:08 Akkitto

It's funny that we don't support properly our own links 🙈 We'll see what we can do about it

idoshamun avatar Aug 21 '25 17:08 idoshamun

This was hard to pull off, required changes in like 4 different repos. I'm waiting for reviews but hopefully we can ship it tomorrow. I'll keep you posted

idoshamun avatar Aug 25 '25 18:08 idoshamun

I managed to get reviews today 🎉 So it's live. Let me know if it fixes the issue please @Akkitto. There's one more enhancement I want to roll out but this will wait a little.

idoshamun avatar Aug 25 '25 20:08 idoshamun

Just posted some post with a link, to test this. Indeed, it seems to be fixed. 🙂

Akkitto avatar Sep 07 '25 13:09 Akkitto

Thanks for confirming the fix!

idoshamun avatar Sep 07 '25 13:09 idoshamun