dagger icon indicating copy to clipboard operation
dagger copied to clipboard

Include support for bun.lock (text based) that was released in Bun 1.2.0

Open joshmeads opened this issue 10 months ago • 2 comments

Adds support for the bun.lock text format released in Bun 1.2.0 bun.sh/blog/bun-v1.2#introducing-bun-lock. This is Bun's new default.

I can't seem to get the test suite and SDK generation working, I've tried from the docs.

dagger call sdk typescript generate export --path=.

Running go test in src/core passes though.

Any advice on finishing up the PR would be appreciated, I'll look at the changie stuff and commit that shortly.

joshmeads avatar Mar 03 '25 03:03 joshmeads

Any advice on finishing up the PR would be appreciated, I'll look at the changie stuff and commit that shortly.

Hey, based on the changes that I'm seeing, you shouldn't need to regenerate clients.

To run tests, you can use the dagger CLI: dagger -m .dagger call test specific --pkg="./core/integration" --run="TypeScript/RuntimeDetection" :)

TomChv avatar Mar 03 '25 11:03 TomChv

@TomChv the command you gave me all passes locally. I still see some things failing on this PR but from what I can see it's unrelated to the PR. I'm unable to see the dagger traces.

Any thoughts? Thanks

joshmeads avatar Mar 05 '25 19:03 joshmeads

@TomChv the command you gave me all passes locally. I still see some things failing on this PR but from what I can see it's unrelated to the PR. I'm unable to see the dagger traces.

Any thoughts? Thanks

Thanks for your patience! Yeah I just had a look and it seems it's some flackes tests, I rebased the PR and will make sure everything is green so we can merge it :)

EDIT: I fixed the DCO check for you, I'm waiting for CI now

TomChv avatar Mar 17 '25 13:03 TomChv