dagger icon indicating copy to clipboard operation
dagger copied to clipboard

✨ Typescript sdk should support overriding base image (like the python sdk does)

Open cchanley2003 opened this issue 1 year ago • 3 comments

What are you trying to do?

Of the 3 main sdks the typescript one doesn't allow for overriding the base image. Go doesn't need it and python has the discovery. Typescript should support similar functionality to the python sdk.

Similar to the python we could put the image override in the config section of the package.json

Why is this important to you?

  1. I want to be able to provide my own base image
  2. For corporate envs may need to pull from a private registry

How are you currently working around this?

Only work around atm is to fork the typescript sdk

cchanley2003 avatar Aug 13 '24 04:08 cchanley2003

It's possible to override the current node version, do you want to actually change the image itself?

https://docs.dagger.io/manuals/developer/typescript/356352/runtime#nodejs

If so, I can add that capabilities

TomChv avatar Oct 08 '24 10:10 TomChv

Yes, change the image not just the version or package manager.

cchanley2003 avatar Oct 08 '24 13:10 cchanley2003

Yes, change the image not just the version or package manager.

Okay I can make that happen, I'll do a change on the runtime :D

TomChv avatar Oct 08 '24 18:10 TomChv