FastExpressionCompiler icon indicating copy to clipboard operation
FastExpressionCompiler copied to clipboard

replace all the method typeof() to cached method. fix test issues

Open cnjimbo opened this issue 3 years ago • 3 comments

1、replace all the method typeof() to cached method. 2、 fix test issues

cnjimbo avatar Jul 11 '22 09:07 cnjimbo

@cnjimbo Thanks for cleaning up, now the scope is much more clear.

I am still hesitating to accept the PR - need to think it over, and ideally to compare new and old benchmarks.

If you can run the benchmarks yourself, it will likely to speed up my decision.

dadhi avatar Jul 12 '22 07:07 dadhi

@dadhi well, agree with you, the full benchmark is necessary. let me figure out a way to test it

cnjimbo avatar Jul 13 '22 06:07 cnjimbo

@cnjimbo The side question, seems like you're deep into the performance optimizations. Maybe you have some other ideas, small or big, regarding the FEC improvements? Honestly, I would not call myself an optimization expert, so I am very open to ideas.

dadhi avatar Jul 18 '22 11:07 dadhi

closing for now.

dadhi avatar Jan 12 '24 19:01 dadhi