Marcus Stöhr

Results 40 comments of Marcus Stöhr

The reason is the "open-closed-principle" which states that classes should be open for extension but closed for modification. To make this happen more extension points are needed. Unless they are...

This is the workaround I used the last time: ``` RUN curl -L -o /tmp/imagick.tar.gz https://github.com/Imagick/imagick/archive/7088edc353f53c4bc644573a79cdcd67a726ae16.tar.gz \ && tar --strip-components=1 -xf /tmp/imagick.tar.gz \ && phpize \ && ./configure \ &&...

Coding Standards fails seem unrelated. @dkarlovi Ok, let's rephrase it then. 😄

> @daFish this looks completed to me, why did you leave is as a draft? I made a small info in the README about it. I will remove the draft...

Hey @maartendekeizer is there anything I can help with? 😄

@weaverryan How should we proceed with this PR?

@CodingBDX I have not yet finished the port in the linked PR. But I just rebased my branch and it is now up-to-date.

> > @CodingBDX I have not yet finished the port in the linked PR. But I just rebased my branch and it is now up-to-date. > > Does this mean...

@janklan After some thoughts I'm not going to finish this. It is based upon the work of @yassinehamouten and I'd rather propose to go with uppy.io - which is already...

@dunglas Is there anything missing here so it can be merged?