implicit_chain_of_thought icon indicating copy to clipboard operation
implicit_chain_of_thought copied to clipboard

Minimal Code to Answer Challenge

Open msghik opened this issue 1 year ago • 0 comments

This is the minimal code change to answer Prof. @da03 challenge.

for adding the teacher states , I had a function called add_two_teacher_states on line 57. Although I believe compressing it down to one line of code would make it less readable and is against my standards for coding, apparently the short version is what Prof. Deng is looking for on line 133. So we stick to it for now.

The only part that is changed are codes between line 120 to 136. In contrast to what Prof. Deng told me on interview, the input_ids for emulator.computer_loss should not be concatenated together since it has already been this way when we are working with two input multiplication.

However, the input_ids for extracting teacher states should be splitted since it is a mixture of two input multiplication and their respective chain of thoughts. we do that on line 124 and create separate input_ids to feed to teacher.extract_states.

Previously I achieved such thing by creating another data.py file, but professor told me that he is looking for minimal changes.

Best,

Mohammad Sadegh Gholizadeh Sum_Emulator

msghik avatar Feb 14 '24 13:02 msghik