code-scanner icon indicating copy to clipboard operation
code-scanner copied to clipboard
verified publisher icon czlucius

Issue 49: Add Dark mode support for OSS Licenses Webview.

Open gauravkhuperkar opened this issue 3 years ago • 1 comments

This PR introduces dark mode support for Open source license dialog.

Code changes: Using WebSettingsCompat.setForceDark (deprecated) for backward compatibility as this app has minimum sdk support as 23. It can be removed once minimum target is set to 29.

Changes are tested with android 10/11 emulator and android 11 physical device. Please find attached testing video. Video quality was reduced because off size limitations.

https://user-images.githubusercontent.com/15320190/198994842-e60eaf37-9ddc-4d01-915a-b9fa5541c958.mov

gauravkhuperkar avatar Oct 31 '22 11:10 gauravkhuperkar

Hi there! Thanks for contributing this patch, your work is much appreciated.

czlucius avatar Nov 01 '22 14:11 czlucius