code-scanner icon indicating copy to clipboard operation
code-scanner copied to clipboard

Dark mode for OSS Licenses Webview

Open czlucius opened this issue 3 years ago • 8 comments

https://joebirch.co/android/enabling-dark-theme-in-android-webviews/

czlucius avatar Jul 25 '22 15:07 czlucius

IntroActivity(On boarding screen displayed for first time after installing an app) also need support for dark mode.

gauravkhuperkar avatar Oct 28 '22 17:10 gauravkhuperkar

There is no IntroActivity

czlucius avatar Oct 29 '22 02:10 czlucius

I think you were referring to the Android 12 splash screen? That's a built in feature of Android.

czlucius avatar Oct 29 '22 04:10 czlucius

Hi @czlucius thanks for quick response. Please find the attched the video of screen -

https://user-images.githubusercontent.com/15320190/198999118-66b27475-09fa-4305-bfd0-c8dd106a1c39.mov

Also, please have a look at this PR I raised for OSS license webview dialog's dark mode supporthttps://github.com/czlucius/code-scanner/pull/55 Thank you

gauravkhuperkar avatar Oct 31 '22 11:10 gauravkhuperkar

Hi @czlucius thanks for quick response. Please find the attched the video of screen - whilte_onbaording_screen_in_dark_mode.mov

Also, please have a look at this PR I raised for OSS license webview dialog's dark mode supporthttps://github.com//pull/55 Thank you

I see. I must have missed out the onboarding screen (CSOnboarding). I use a library for this, do you want to go work on it?

czlucius avatar Nov 01 '22 14:11 czlucius

Is this issue still open I want to collaborate?

hhugoac avatar Jul 17 '23 16:07 hhugoac

Sure Can you take a look at the PR?

czlucius avatar Jul 18 '23 09:07 czlucius

https://github.com/czlucius/code-scanner/pull/55

czlucius avatar Jul 18 '23 09:07 czlucius