code-coverage icon indicating copy to clipboard operation
code-coverage copied to clipboard

fix: filterSpecsFromCoverage should only filter specs

Open skimi opened this issue 5 years ago • 3 comments

#326

skimi avatar Oct 27 '20 09:10 skimi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 27 '20 09:10 CLAassistant

@bahmutov I've rebased to master an I've added a test for the reported case

But to be honest, imo the function could just filter out every files in the integration folder. I don't really see a case where one would want the code coverage to include anything from the integration folder 🤷‍♂️. So all the logic looking at the testFiles pattern could just be removed imo

skimi avatar Feb 28 '21 10:02 skimi

Just ran into this issue. @skimi did you workaround this?

@bahmutov if I open up a new PR with this rebased off of the default branch, would that work?

eraffel-MDSol avatar Mar 30 '22 07:03 eraffel-MDSol