cyclops icon indicating copy to clipboard operation
cyclops copied to clipboard

adds printer columns for cyclops modules

Open ashish111333 opened this issue 1 year ago • 8 comments

closes #428

📑 Description

This PR adds printer columns for cyclops modules.

✅ Checks

  • [ ] I have updated the documentation as required
  • [x] I have performed a self-review of my code

Additional context

ashish111333 avatar Aug 02 '24 23:08 ashish111333

To generate CRD yamls, you need to run make manifests and make generate from the cyclops-ctrl which will update yamls in cyclops-ctrl/config/crd/bases. I tried it on my local machine, but my version of go and version of controller-gen are not compatible.

@ashish111333 can you run those two commands and commit the changes generated?

petar-cvit avatar Aug 04 '24 08:08 petar-cvit

I see their is a bug in controller-gen .11 that causes panic, we should update it.

ashish111333 avatar Aug 04 '24 11:08 ashish111333

Yup, found this comment on a controller gen issue

petar-cvit avatar Aug 04 '24 11:08 petar-cvit

@petar-cvit done.

ashish111333 avatar Aug 04 '24 14:08 ashish111333

@ashish111333 tried it locally, and controller-gen now works. However, it seems like it didn't generate additionalPrinterColumns . Can you look into that?

petar-cvit avatar Aug 05 '24 10:08 petar-cvit

@ashish111333 tried it locally, and controller-gen now works. However, it seems like it didn't generate additionalPrinterColumns . Can you look into that?

Let me try, will update you.

ashish111333 avatar Aug 05 '24 10:08 ashish111333

@ashish111333 did you manage to generate printer columns?

petar-cvit avatar Sep 04 '24 08:09 petar-cvit

@petar-cvit Got a little busy , I will try to finish it this week.

ashish111333 avatar Sep 04 '24 09:09 ashish111333