react icon indicating copy to clipboard operation
react copied to clipboard

jsxFactory should be export from this package, not from @cycle/react-dom

Open ryota-ka opened this issue 5 years ago • 3 comments

Problem

jsxFactory should be export from @cycle/react, not from @cycle/react-dom.

Why

There are many DOM-free React projects in the world such as Ink and Adapt.

Library versions

package version
@cycle/react v2.7.0
@cycle/react-dom v2.4.0

ryota-ka avatar May 04 '20 16:05 ryota-ka

Hmm, good point! PRs welcomed (hopefully 2 PRs, one to remove JSX pragma from @cycle/react-dom, another to add it here in @cycle/react)

staltz avatar May 04 '20 16:05 staltz

Okay, I'll submit a pull request in a few days! (Luckily, now it's on holidays in Japan :blush:)

BTW, instead of removing it from @cycle/react-dom at once, what do you think of deprecating it and remove it in the next major version bump?

ryota-ka avatar May 05 '20 17:05 ryota-ka

BTW, instead of removing it from @cycle/react-dom at once, what do you think of deprecating it and remove it in the next major version bump?

Even better idea!

staltz avatar May 06 '20 17:05 staltz