Chao Yang comments

Results 58 comments of


                                            Chao Yang

Add boolean flag skip_router to Context

@grkek Please review.

Add boolean flag skip_router to Context

@grkek This is to skip the router handlers dynamically per request.

Update crystal and pg versions in CI

Tests are broken with crystal 1.13.1 due to https://github.com/crystal-lang/crystal/pull/11208

Update crystal and pg versions in CI

@imdrasil Please take a look.

Fully qualified name must be used inside a block when assigning to an ivar.

It seems like jennifer fails to build due to the same issue here. https://github.com/imdrasil/jennifer.cr/issues/460

Fully qualified name must be used inside a block when assigning to an ivar.

The jennifer failure is indeed caused by #11181, the tests passed after reverting the code change in #11208

Unable to build Jennifer in 1.13.*

Jennifer fails to build with crystal 1.13.1 https://github.com/imdrasil/jennifer.cr/actions/runs/10276277611/job/28436462078?pr=461#step:10:29

Fix interpreter when inlining pure `InstanceVar` virtual def and only one concrete subclass exists

@HertzDevil I was just wondering if AI could help this project or not, so I gave it a try. Below is the chat history including the chain of thoughts, I...

Fix interpreter when inlining pure `InstanceVar` virtual def and only one concrete subclass exists

OK, so it's better to provide summary of AI analysis to the github issue first before creating a PR. And it looks like the AI is helpful at finding root...

Fix crystal_type_id for interpreter

~~No idea why `!owner.nilable?` check is necessary here. If runtime type is nil, it reaches to Nil#crystal_type_id which returns hard coded value 0.~~ Removing `!owner.nilable?` check causes invalid memory access...