smartcd icon indicating copy to clipboard operation
smartcd copied to clipboard

smartcd fixes

Open garethstockwell opened this issue 13 years ago • 2 comments

  • Temporarily disable noclobber for bash
  • Fix script mapping by always using physical paths

garethstockwell avatar May 03 '12 12:05 garethstockwell

I like the noclobber fix. I think I will generalize the bash option-setting code to handle other options, just in case.

The "cd -P vs pwd -P" situation is one I'm not sure about. I may want to make that configurable, since some users may like the current behavior.

Thanks for your patches!

cxreg avatar May 18 '12 17:05 cxreg

You're welcome. I have some more patches which I will submit once I've tested them a bit more.

smartcd is a great tool which I was happy to discover recently. I had previously written my own very basic cd hook which allowed me to set environment variables (but without autostashing nor recursion) and execute shell commands. But since smartcd is so much more powerful and generic, I switched to it immediately.

Nice work!

Gareth

Sent from my Nokia N9

On 18/05/2012 18:25 Dave Olszewski wrote:

I like the noclobber fix. I think I will generalize the bash option-setting code to handle other options, just in case.

The "cd -P vs pwd -P" situation is one I'm not sure about. I may want to make that configurable, since some users may like the current behavior.

Thanks for your patches!


Reply to this email directly or view it on GitHub: https://github.com/cxreg/smartcd/pull/5#issuecomment-5791216


Subject to local law, communications with Accenture and its affiliates including telephone calls and emails (including content), may be monitored by our systems for the purposes of security and the assessment of internal compliance with Accenture policy.


www.accenture.com

garethstockwell avatar May 18 '12 17:05 garethstockwell