espn-api icon indicating copy to clipboard operation
espn-api copied to clipboard

Add Draft

Open cwendt94 opened this issue 3 years ago • 3 comments

Sport

Basketball

Summary

Add the leagues draft for the given year

cwendt94 avatar May 02 '22 15:05 cwendt94

I will try to work on this! I plan on using porting the draft classes from the football leagues into the basketball ones.

This is my first time contributing, any guidance or advice would be appreciated!

ZenHWu avatar May 02 '22 20:05 ZenHWu

@cwendt94

Hi there, I have forked and cloned the repository into a local directory and made my changes. However, when I attempt to run any of the files in the repo, it gives me an error like so: image

Any advice or suggestions? I'm looking for an efficient way to test my changes locally.

Thanks!

ZenHWu avatar May 02 '22 21:05 ZenHWu

Thanks for taking on this ticket! I definitely think that's the right idea looking at the football draft logic!

Hmm from a quick look I think it's because you are trying to run the basketball league.py as a single file. You could try loading the package at the top level. I usually make changes then start up python cli inside the top level GitHub project. Then can load the league how you would normally

from espn_api.basketball import League

cwendt94 avatar May 03 '22 02:05 cwendt94

Didn't see any updates on this so I created a PR here

cjwin2000 avatar Dec 15 '22 23:12 cjwin2000

Draft feature now in v0.29.0!

cwendt94 avatar Dec 16 '22 17:12 cwendt94