react-wordle icon indicating copy to clipboard operation
react-wordle copied to clipboard

Updated styling for settings and win modal, add prettier class sorting, and fixed unit testing bugs.

Open theotarr opened this issue 4 years ago • 5 comments

Styling Changes

  • added rounded borders to guess distribution metrics
  • changed share button to blue and added a transition effect (the indigo clashed with the other blues)
  • updated centering and font colors on the settings options

Class Sorting

Added Prettier Class Sorting and formatted the whole project.

Unit Test Fix

Sort of a hacky fix, but now the share testing mock is initialized and working.

theotarr avatar Mar 24 '22 23:03 theotarr

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cwackerfuss/react-wordle/DouFiq5TahjqvKhrEAUETgigcq2C
✅ Preview: https://react-wordle-git-fork-theotarr-main-cwackerfuss.vercel.app

vercel[bot] avatar Mar 24 '22 23:03 vercel[bot]

Hi,

Since you submitted this, there's been some changes, e.g. the unit test bug no longer appears. Can you please rebase on the latest commit in master?

igitur avatar May 06 '22 06:05 igitur

Also log the class sorting as a separate PR, please.

igitur avatar May 06 '22 07:05 igitur

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-wordle ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 9:13AM (UTC)

vercel[bot] avatar Aug 10 '22 13:08 vercel[bot]

Hi @theotarr. I'm not sure if you're still interested in this PR, but I had a look at it and reworked the commits a bit. I also split out a commit into its own PR at #492 . Would you mind having a look at the restructure of the commits and giving feedback. I also have some subsequent comments once you're done. Thanks

igitur avatar Aug 10 '22 14:08 igitur