react-planner icon indicating copy to clipboard operation
react-planner copied to clipboard

Feature/add export

Open JaccoGoris opened this issue 6 years ago • 7 comments

Added the ability to extract a 3D Collada file from the scene. Reworked the way the walls are built because the way it was done was causing a lot of shading issues in other 3D software

Fix for #167

JaccoGoris avatar Apr 03 '19 11:04 JaccoGoris

We moved our fork to the organisation, that's why this one is coming from "around media"

JaccoGoris avatar Apr 03 '19 11:04 JaccoGoris

Updated my PR since the newest version of three allows the use of imports for the examples (finally) this is necessary because else the planner could not be used as a lib anymore.

JaccoGoris avatar Apr 05 '19 08:04 JaccoGoris

Sorry for the late response but I was very busy in these days... I am not fully convinced by your pull requests, so I will try to accomplish same results with little modifications of your code base... In particular I was able to obtain an empty collada scene as the setTimeout was invoked before the scene parsing was complete

danilosalvati avatar May 02 '19 02:05 danilosalvati

@danilosalvati, No problem at all! Since then I had found a couple of the same issues, and I've reworked it a bit already, there's a timeout now and I've changed to logic to work as an Action, rather than putting the functionality straight in the export button. it works much better now.

Though, for my tests when using it in a create react app: having the texture in the mtl file is problematic as it doesn't find it and the export fails. so that might have to change in the future.

do you still want me to update my PR or do you want to try yourself?

JaccoGoris avatar May 02 '19 07:05 JaccoGoris

I have an idea I would like to test... so I think I will try myself for now

danilosalvati avatar May 02 '19 23:05 danilosalvati

Okay! very well :)

JaccoGoris avatar May 03 '19 07:05 JaccoGoris

@danilosalvati thanks for your work on this project. Can you please merge some of the awesome features @JaccoGoris has built here? Alternatively, the project will likely continue on a new fork

ericvanular avatar Jul 23 '20 14:07 ericvanular