ox icon indicating copy to clipboard operation
ox copied to clipboard

PHP syntax highlighting

Open duboiss opened this issue 5 years ago • 2 comments

Is your feature request related to a problem? Please describe. It would be nice if we can add a support for PHP syntax highlighting. I also think there are some similarities with the current JavaScript support (comments, functions...).

Why not have an issue where people can request support for a particular file extension and then they can vote ? To add support to the most requested in priority.

Thanks!

duboiss avatar Nov 06 '20 12:11 duboiss

Sure, shouldn't be too hard. I am writing some documentation at the moment to educate how to configure and create custom syntax highlighting but I'm more than happy to create PHP syntax highlighting if I get the time.

As for the idea where people can request support for a particular file extension, I could open one issue and pin it where people can comment for certain file types however there aren't enough language requests and I'll probably add language support using a list of popular programming languages and just work my way down to cover most of the popular languages and then perhaps the more obscure ones can open individual issues.

curlpipe avatar Nov 06 '20 17:11 curlpipe

You are awesome. I'm not a Rust developer but I have found the ox.ron where syntax highlighting is handled. After see it, I think I havent the knowledge for PR... so sorry about that.

I talked about the new issue because some file extensions do not correspond to a programming language. .env is an exemple. We can also mention .json, .htm / .html, .css...

But I obviously don't want you to focus 100% of your development on it!

Thanks you for your work!

duboiss avatar Nov 06 '20 17:11 duboiss