refactor(cubesql): Extract cube join condition check for rewrites to separate function

[mcheshkov]

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
examples-angular-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am
examples-react-d3	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am
examples-react-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am
examples-react-data-table	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am
examples-react-highcharts	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am
examples-react-material-ui	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am
examples-react-pivot-table	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am
examples-vue-query-builder	⬜️ Ignored (Inspect)	Visit Preview		Nov 13, 2024 11:55am

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (5fd13d1) to head (4659f8c). Report is 139 commits behind head on master.

Files with missing lines	Patch %	Lines
...besql/cubesql/src/compile/rewrite/rules/members.rs	98.70%	1 Missing :warning:

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8835   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         221      221           
  Lines       78303    78318   +15     
=======================================
+ Hits        64726    64742   +16     
+ Misses      13577    13576    -1     

Flag	Coverage Δ
cubesql	82.66% <98.70%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[mcheshkov]

Merged as part of https://github.com/cube-js/cube/pull/9032