cube icon indicating copy to clipboard operation
cube copied to clipboard

refactor(cubesql): Extract CubeScanWrappedSqlNode from CubeScanWrapperNode

Open mcheshkov opened this issue 1 year ago • 2 comments

Check List

  • [x] Tests has been run in packages where changes made if available
  • [x] Linter has been run for changed code
  • [x] Tests for the changes have been added if not covered yet
  • [x] Docs have been added / updated if required

mcheshkov avatar Oct 04 '24 19:10 mcheshkov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 0:54am

vercel[bot] avatar Oct 04 '24 19:10 vercel[bot]

Codecov Report

Attention: Patch coverage is 89.41176% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (591a383) to head (8d6b0d0). Report is 126 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/mod.rs 89.28% 6 Missing :warning:
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 4 Missing :warning:
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 92.00% 4 Missing :warning:
...t/cubesql/cubesql/src/compile/test/test_wrapper.rs 93.47% 3 Missing :warning:
rust/cubesql/cubesql/src/compile/test/utils.rs 83.33% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8786      +/-   ##
==========================================
- Coverage   82.69%   82.65%   -0.04%     
==========================================
  Files         221      221              
  Lines       78467    78265     -202     
==========================================
- Hits        64888    64691     -197     
+ Misses      13579    13574       -5     
Flag Coverage Δ
cubesql 82.65% <89.41%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '24 19:10 codecov[bot]

Merged as part of #9032

mcheshkov avatar Jan 14 '25 19:01 mcheshkov