fix(cubesql): Use proper column type for time measures
Check List
- [x] Tests has been run in packages where changes made if available
- [x] Linter has been run for changed code
- [x] Tests for the changes have been added if not covered yet
- [x] Docs have been added / updated if required
Description of Changes Made (if issue reference is not provided)
[Description goes here]
Use ColumnType::Timestamp for column for min/max(time) measures instead ColumnType::Double. Before it would try to parse strings like "2024-12-31T00:00:00.000" from CubeScan as f64.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.57%. Comparing base (
1afa934) to head (c901460). Report is 255 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #8623 +/- ##
=======================================
Coverage 82.56% 82.57%
=======================================
Files 209 209
Lines 77011 77062 +51
=======================================
+ Hits 63585 63633 +48
- Misses 13426 13429 +3
| Flag | Coverage Δ | |
|---|---|---|
| cubesql | 82.57% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves these issues 🚀
- https://github.com/cube-js/cube/issues/8153
- https://github.com/cube-js/cube/issues/5652
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| examples-angular-dashboard | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm | |
| examples-react-d3 | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm | |
| examples-react-dashboard | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm | |
| examples-react-data-table | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm | |
| examples-react-highcharts | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm | |
| examples-react-material-ui | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm | |
| examples-react-pivot-table | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm | |
| examples-vue-query-builder | ⬜️ Ignored (Inspect) | Visit Preview | Aug 26, 2024 10:34pm |